From: Carlos Garnacho <carlosg@gnome.org>
Date: Fri, 13 Jul 2018 22:14:07 +0000 (+0200)
Subject: keyboard: defer position-changed till we have a rect
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~929^2~3^2~27
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=81956e9b84a751e0aae739ef08017d3bfef907c8;p=gnome-shell.git

keyboard: defer position-changed till we have a rect

Emitting it that soon results in JS warnings, as we don't have
everything in place yet. The position-changed signal will be
emitted from other locations as soon as we have it.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/464

Closes: #464
---

diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 1666a507b..4a2494044 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -526,9 +526,7 @@ var FocusTracker = new Lang.Class({
         this._currentWindow = window;
         if (window) {
             this._currentWindowPositionId = this._currentWindow.connect('position-changed', () => {
-                if (global.display.get_grab_op() == Meta.GrabOp.NONE)
-                    this.emit('position-changed');
-                else
+                if (global.display.get_grab_op() != Meta.GrabOp.NONE)
                     this.emit('reset');
             });
         }